Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.6.latest] Preserve decimal places for dbt show #8588

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2023

Backport be94bf1 from #8561.

* update `Number` class to handle integer values (#8306)

* add show test for json data

* oh changie my changie

* revert unecessary cahnge to fixture

* keep decimal class for precision methods, but return __int__ value

* jerco updates

* update integer type

* update other tests

* Update .changes/unreleased/Fixes-20230803-093502.yaml

---------

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>

* account for integer vs number on table merges

* add tests for combining number with integer.

* add unit test when nulls are added

* cant none as an Integer

* fix null tests

---------

Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com>
Co-authored-by: Dave Connors <dave.connors@fishtownanalytics.com>
(cherry picked from commit be94bf1)
@github-actions github-actions bot requested a review from a team as a code owner September 7, 2023 14:27
@github-actions github-actions bot requested a review from ChenyuLInx September 7, 2023 14:27
@cla-bot cla-bot bot added the cla:yes label Sep 7, 2023
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop requested a review from graciegoheen September 7, 2023 14:56
@emmyoop
Copy link
Member

emmyoop commented Sep 7, 2023

tests hanging, close/reopen

@emmyoop emmyoop closed this Sep 7, 2023
@emmyoop emmyoop reopened this Sep 7, 2023
@emmyoop emmyoop closed this Sep 7, 2023
@emmyoop emmyoop reopened this Sep 7, 2023
@emmyoop emmyoop merged commit e150626 into 1.6.latest Sep 7, 2023
@emmyoop emmyoop deleted the backport-8561-to-1.6.latest branch September 7, 2023 16:48
emmyoop added a commit that referenced this pull request Sep 7, 2023
emmyoop added a commit that referenced this pull request Sep 7, 2023
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants